feat(sentry-native): add options_set_native_database_path option
#3236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3236 +/- ##
==========================================
+ Coverage 87.94% 89.36% +1.41%
==========================================
Files 290 95 -195
Lines 9984 3393 -6591
==========================================
- Hits 8780 3032 -5748
+ Misses 1204 361 -843 ☔ View full report in Codecov by Sentry. |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4298701 | 1243.56 ms | 1262.29 ms | 18.72 ms |
| 640ad0c | 1241.04 ms | 1253.96 ms | 12.92 ms |
| 32914d8 | 1275.47 ms | 1285.20 ms | 9.73 ms |
| fd88186 | 1255.06 ms | 1252.76 ms | -2.30 ms |
| 827bf09 | 1261.86 ms | 1276.41 ms | 14.55 ms |
| 575ebaa | 1262.20 ms | 1274.24 ms | 12.04 ms |
| 79f6b41 | 1269.33 ms | 1279.71 ms | 10.38 ms |
| dbd526b | 1244.78 ms | 1259.02 ms | 14.24 ms |
| c26ed0a | 1244.11 ms | 1263.85 ms | 19.75 ms |
| c8596a6 | 1234.11 ms | 1241.19 ms | 7.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4298701 | 20.70 MiB | 22.46 MiB | 1.76 MiB |
| 640ad0c | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 32914d8 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| fd88186 | 5.53 MiB | 6.00 MiB | 479.94 KiB |
| 827bf09 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 575ebaa | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 79f6b41 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| dbd526b | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| c26ed0a | 5.53 MiB | 5.97 MiB | 453.76 KiB |
| c8596a6 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7cfee3b | 498.78 ms | 516.98 ms | 18.20 ms |
| 765aa8b | 493.51 ms | 531.23 ms | 37.72 ms |
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
| 3615e19 | 468.38 ms | 504.71 ms | 36.33 ms |
| 93b7728 | 475.28 ms | 489.13 ms | 13.86 ms |
| 32914d8 | 461.96 ms | 495.47 ms | 33.51 ms |
| 793f4dc | 462.68 ms | 544.21 ms | 81.53 ms |
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| 2cb90b9 | 479.38 ms | 552.69 ms | 73.31 ms |
| c8596a6 | 474.00 ms | 492.96 ms | 18.96 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7cfee3b | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| 765aa8b | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 3615e19 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 93b7728 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 32914d8 | 6.54 MiB | 7.70 MiB | 1.16 MiB |
| 793f4dc | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 2cb90b9 | 6.54 MiB | 7.70 MiB | 1.17 MiB |
| c8596a6 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
denrase
approved these changes
Sep 5, 2025
Collaborator
denrase
left a comment
denrase
left a comment
There was a problem hiding this comment.
LGTM, just some questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds options to configure the database path for Sentry Native
💡 Motivation and Context
Closes #2585
💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps